Skip to content

OCPBUGS#42519: Clarify Operator group RBAC hash values #90580

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 20, 2025
Merged

OCPBUGS#42519: Clarify Operator group RBAC hash values #90580

merged 1 commit into from
Mar 20, 2025

Conversation

michaelryanpeter
Copy link
Contributor

@michaelryanpeter michaelryanpeter commented Mar 18, 2025 •
edited
Loading

Version(s): 4.15+

Issue: OCPBUGS-42519

Link to docs preview:
https://90580--ocpdocs-pr.netlify.app/openshift-enterprise/latest/operators/understanding/olm/olm-understanding-operatorgroups.html

QE review:

  • QE has approved this change.

Additional information:

@michaelryanpeter michaelryanpeter added this to the Continuous Release milestone Mar 18, 2025
@openshift-ci openshift-ci bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Mar 18, 2025
@ocpdocs-previewbot
Copy link

ocpdocs-previewbot commented Mar 18, 2025 •
edited
Loading

🤖 Thu Mar 20 19:14:05 - Prow CI generated the docs preview:

https://90580--ocpdocs-pr.netlify.app/openshift-dedicated/latest/operators/understanding/olm/olm-understanding-operatorgroups.html
https://90580--ocpdocs-pr.netlify.app/openshift-enterprise/latest/operators/understanding/olm/olm-understanding-operatorgroups.html
https://90580--ocpdocs-pr.netlify.app/openshift-rosa-hcp/latest/operators/understanding/olm/olm-understanding-operatorgroups.html
https://90580--ocpdocs-pr.netlify.app/openshift-rosa/latest/operators/understanding/olm/olm-understanding-operatorgroups.html

@michaelryanpeter michaelryanpeter force-pushed the ocpbugs-42519-clarify-operator-group-rbac-hash branch from 33c907e to 0ce97fc Compare March 18, 2025 18:51
@michaelryanpeter
Copy link
Contributor Author

@jianzhangbjz Would you PTAL and assign or review the PR? Thank you!

@jianzhangbjz
Copy link

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Mar 20, 2025
@michaelryanpeter
Copy link
Contributor Author

/label peer-review-needed

@openshift-ci openshift-ci bot added the peer-review-needed Signifies that the peer review team needs to review this PR label Mar 20, 2025
@jeana-redhat jeana-redhat added the peer-review-in-progress Signifies that the peer review team is reviewing this PR label Mar 20, 2025
jeana-redhat
jeana-redhat reviewed Mar 20, 2025
View reviewed changes
Copy link
Contributor

@jeana-redhat jeana-redhat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nitty nits

/remove-label peer-review-in-progress
/remove-label peer-review-needed
/label peer-review-done

@openshift-ci openshift-ci bot added peer-review-done Signifies that the peer review team has reviewed this PR and removed peer-review-in-progress Signifies that the peer review team is reviewing this PR peer-review-needed Signifies that the peer review team needs to review this PR labels Mar 20, 2025
@michaelryanpeter michaelryanpeter force-pushed the ocpbugs-42519-clarify-operator-group-rbac-hash branch from 0ce97fc to bcebd8c Compare March 20, 2025 19:03
@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Mar 20, 2025
@openshift-ci OpenShift CI
Copy link

openshift-ci bot commented Mar 20, 2025

New changes are detected. LGTM label has been removed.

@openshift-ci OpenShift CI
Copy link

openshift-ci bot commented Mar 20, 2025

@michaelryanpeter: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@michaelryanpeter michaelryanpeter merged commit 7999f89 into openshift:main Mar 20, 2025
2 checks passed
@michaelryanpeter
Copy link
Contributor Author

/cherrypick enterprise-4.19

@michaelryanpeter
Copy link
Contributor Author

/cherrypick enterprise-4.18

@michaelryanpeter
Copy link
Contributor Author

/cherrypick enterprise-4.17

@michaelryanpeter
Copy link
Contributor Author

/cherrypick enterprise-4.16

@michaelryanpeter
Copy link
Contributor Author

/cherrypick enterprise-4.15

@openshift-cherrypick-robot
Copy link

@michaelryanpeter: new pull request created: #90830

In response to this:

/cherrypick enterprise-4.19

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Mar 20, 2025
Merged
@openshift-cherrypick-robot
Copy link

@michaelryanpeter: new pull request created: #90831

In response to this:

/cherrypick enterprise-4.18

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Mar 20, 2025
Merged
@openshift-cherrypick-robot
Copy link

@michaelryanpeter: new pull request created: #90832

In response to this:

/cherrypick enterprise-4.17

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Mar 20, 2025
Merged
@openshift-cherrypick-robot
Copy link

@michaelryanpeter: new pull request created: #90833

In response to this:

/cherrypick enterprise-4.16

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Mar 20, 2025
Merged
@openshift-cherrypick-robot
Copy link

@michaelryanpeter: new pull request created: #90834

In response to this:

/cherrypick enterprise-4.15

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Mar 20, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jeana-redhat jeana-redhat jeana-redhat left review comments

@ocpdocs-vale-bot ocpdocs-vale-bot ocpdocs-vale-bot left review comments

@perdasilva perdasilva perdasilva approved these changes

Assignees

@jianzhangbjz jianzhangbjz

Labels
branch/enterprise-4.15 branch/enterprise-4.16 branch/enterprise-4.17 branch/enterprise-4.18 branch/enterprise-4.19 peer-review-done Signifies that the peer review team has reviewed this PR size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
Continuous Release
Development

Successfully merging this pull request may close these issues.
7 participants
@michaelryanpeter @ocpdocs-previewbot @jianzhangbjz @openshift-cherrypick-robot @perdasilva @jeana-redhat @ocpdocs-vale-bot